-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Android build setup #1228
Open
SaschaWillems
wants to merge
15
commits into
KhronosGroup:main
Choose a base branch
from
SaschaWillems:android_build_setup_update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update Android build setup #1228
SaschaWillems
wants to merge
15
commits into
KhronosGroup:main
from
SaschaWillems:android_build_setup_update
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t compiles on Android Should also fix KhronosGroup#912
Use of ALooper_pollAll has been deprecated on current Android versions
This has been deprecated with recent Android version Package name now comes from gradle setup
Had a wrong "release only"dependency
It's lower case on all platforms, upper case only works properly on windows
SaschaWillems
added
build
This is relevant to the build system
android
Issues related to the Android platform
labels
Nov 16, 2024
marty-johnson59
requested review from
JoseEmilio-ARM,
gpx1000 and
wasimabbas-arm
and removed request for
JoseEmilio-ARM
November 18, 2024 16:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Android build setup for our samples is heavily outdated, making it impossible to locally build them with recent Android build tools (e.g. Android Studio) unless you find a way to manually download and setup the exact versions of the build related tools we require,
This makes it nigh impossible to easily build our samples on Android.
This PR fully updates our Android build scripts and setups to support up-to-date Android build tools, including the current version of Android Studio ("Ladybug"). So people wanting to build on Android can simply download Android studio, generate the project files and then easily build the samples.
It also fixes a few issue with our build files that only showed up with more recent build tools. One such change is a deprecation in the native bridge from C++ to Android, which required a fix in the framework (otherwise it would no longer compile).
Note that this is a fairly pervasive change. I did multiple builds, both release and debug from a clean setup to make sure this properly works. I also had to update some third party dependencies to make everything compile with updated compiler toolchains used on Android. I also updated the Android validation layers to the most recent release.
This hopefully fixes all the reported issues people had with trying to build our samples on Android.
Fixes #1188
Fixes #1185
Fixes #1178
Fixes #912
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batch
command line argument to make sure all samples still work properlyNote: It does a famework change for Android, but afaik we don't have batch mode on Android. I did test several samples though.